Handle multiple and expanded sources properly#5
Open
smcgivern wants to merge 1 commit into
Open
Conversation
`done` should only be called once, but was called multiple times if either: - The `src` option was set to an array of files. - The `expand` option was enabled and that expanded to more than one file.
|
@jdavis could you please either land this and publish a new version or mark this project as dead and not to be used? Introducing the grunt-rename task into a project breaks the build because of this issue. |
Owner
|
I don't use Node much anymore; I'll probably just deprecate this as I'm spread too thin. |
Author
|
Please do; it's not your fault, but Grunt's async API is a) kind of insane (it shouldn't be so easy to break other tasks) and b) hard to debug. @csnover if you really want this plugin, you can use my branch in your "grunt-rename": "git://github.com/smcgivern/grunt-rename.git#support_src_arrays" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doneshould only be called once, but was called multiple times if either:srcoption was set to an array of files.expandoption was enabled and that expanded to more than one file.This would break future async grunt tasks. The destination would also be set to the same filename for all elements in
srcarrays, which is fixed in this branch too.